Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Michael Dawson's name (for consistency) #2010

Merged
merged 4 commits into from
Feb 1, 2019
Merged

Added Michael Dawson's name (for consistency) #2010

merged 4 commits into from
Feb 1, 2019

Conversation

ThePrez
Copy link
Contributor

@ThePrez ThePrez commented Jan 24, 2019

For consistent format with the others listed.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZYSzys
Copy link
Member

ZYSzys commented Jan 29, 2019

Ping @ThePrez , could you please land @richardlau's suggestions ?

richardlau and others added 3 commits January 31, 2019 14:53
@ThePrez
Copy link
Contributor Author

ThePrez commented Jan 31, 2019

Thanks, @richardlau, for noting my header level incorrectness. I'm not good at details and I think I was thrown off by the misplaced "British Columbia" header (also possibly the lack of a city for Ontario), both of which I've corrected in my latest commits.

@ZYSzys ZYSzys merged commit 8b6e900 into nodejs:master Feb 1, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Feb 1, 2019

Thanks👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants