Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN:Trans for 'diagnostics-flamegraph.md' #2103

Merged
merged 2 commits into from Feb 21, 2019
Merged

zh-CN:Trans for 'diagnostics-flamegraph.md' #2103

merged 2 commits into from Feb 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2019

  1. Trans for Chinese of the file:'diagnostics-flamegraph.md'.
  2. Fix some typo errors in the related English version.

Ref:#1444

1) Trans for Chinese of the file:'diagnostics-flamegraph.md'.
2) Fix some typo errors in the related English version.
@ghost
Copy link
Author

ghost commented Feb 21, 2019

@naugtur:Please have a review, there're some changes in the English version.

@ghost ghost requested a review from fhemberger February 21, 2019 10:16
@ghost
Copy link
Author

ghost commented Feb 21, 2019

@nodejs/nodejs-cn:Please have a review of translation, thanks!

@ghost ghost requested a review from ZYSzys February 21, 2019 11:26
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, maybe it’s a good time to update all node or Node to Node.js for consistency :)

Copy link

@Lellansin Lellansin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Feb 21, 2019

@ZYSzys:Thanks and I've unioned all in both English and Chinese.

@ZYSzys
Copy link
Member

ZYSzys commented Feb 21, 2019

Cool ! Thank you~ 👍

@ZYSzys ZYSzys merged commit 9088433 into nodejs:master Feb 21, 2019
@ghost ghost deleted the TransFlame branch February 21, 2019 12:08
@naugtur
Copy link
Contributor

naugtur commented Mar 12, 2019

Great work, sorry I was not available earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants