-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the packages for some bugs' fixtures #2172
Conversation
The The current master with
After checking out the PR, running the same command again (I've renamed the previous
I don't know if just something on my local build is borked, so PTAL before merging. |
@fhemberger:This seems a little odd……Here's my index page when running Here's the result after So when you remove all the things in "node_modules" and try to run with |
1) IMPORTANT Fix:Update the 'marked' package, because there's an existing BUG reported by @rvagg, and this is already fixed in its v0.6.2. For more Ref:#2119. Fixture:markedjs/marked#1434. 2) A general upgration of the two packages: a) require-dir: 1.0.0 => 1.2.0 b) semver: 5.6.0 => 6.0.0 (Fix a technical bug, important)
Now I've removed the 'package-lock.json' and reinstall all the packages, you can have a try :) |
Hmm, still the same for me, even with
🤔 If someone else can confirm the changes are working for them, I'm fine with merging this PR. |
So @fhemberger , when running I'm now digging to find what's the matter with that……I'm on Windows 10 (x86, the lastest version of Nodejs, the OS is 17134.648). |
@Maledong |
When browsing the homepage, the download buttons show direct download links to the detected platform. For Linux, only 64bit builds are supported as of 10.0.0. Fixes #2172
The |
Not sure it's worth it with the upcoming relaunch just around the corner. |
IMPORTANT Fix:Update the 'marked' package, because there's an existing BUG
reported by @rvagg, and this is already fixed in its v0.6.2.
Ref:Markdown parsing problem #2119.
Fixture:[Bug] We have to use '\' to add the '(' markedjs/marked#1434.
A general upgration of the two packages:
a) require-dir: 1.0.0 => 1.2.0
b) semver: 5.6.0 => 6.0.0 (Fix a technical bug).
All syntaxes passed with unit tests