-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide: "Anatomy of an HTTP Request" #218
Add guide: "Anatomy of an HTTP Request" #218
Conversation
@nodejs/documentation @nodejs/website Can I get a LGTM, just for good measure? :) |
+1 |
The only thing I would add here is that the links to API docs are all linking to iojs.org, which was because at the time, nodejs.org did not have modern API docs. This should probably be changed, and now's a good time. |
Ah, yep. I'll fix that. This was just a quick port of the commits. I didn't really look too closely at the content, since it had already gone through review on https://github.com/nodejs/docs. |
Nice! Any plans for listing these guides? A completely new section or under docs maybe? |
@phillipj yes, I think a 'Guides' section would be great for these kind of things. I had basically the same idea over at nodejs/docs#42. |
The original plan for the docs wg, discussed back at nodeconf, was to sort docs into topics, guides and reference. We kind of dropped the ball on coordinating with website to figure out how this stuff would all appear though, which is what I'm working on fixing now. 😸 |
Looking forward to having these resources on the website 👍 @Qard so lets merge this content now, and figure out the best way to group/present them later in a separate issue? |
s/iojs.org/nodejs.org/
Ok, it should be ready now. I just had to fix some links. I'm good with merging and starting another PR to sort out linking to this content. |
Now we have PRs for adding pages as docs, meta docs, guides, topics and knowledge base. This is confusing for the users (at least it is for me now). I think having less categories (and/or a clearer structure) would be a better approach. Otherwise LGTM. |
Add guide: "Anatomy of an HTTP Request"
Merged, although it's not linked on the site yet. |
Note: This is part of the migration of content files from https://github.com/nodejs/docs, see: nodejs/docs#44