Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Fix v8.dev link in v12.5.0 release post #2300

Merged
merged 2 commits into from
Jun 29, 2019

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Jun 27, 2019

This fixes the v8.dev link to not act as a relative URL in https://nodejs.org/en/blog/release/v12.5.0/. Currently in links to https://nodejs.org/en/blog/release/v12.5.0/v8.dev/features/numeric-separators, but this PR fixes it to https://v8.dev/features/numeric-separators

@devsnek
Copy link
Member

devsnek commented Jun 27, 2019

thank you! would you mind also adding links to the notable changes' prs? see https://github.com/nodejs/node/pull/28450/files

@Cherry
Copy link
Contributor Author

Cherry commented Jun 27, 2019

Done, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants