-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog: add #28630 to "notable" section of v12.7.0 release #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you revert the other changes? LGTM otherwise |
oops. blame prettier |
boneskull
force-pushed
the
notable-12.7.0
branch
from
July 25, 2019 17:10
ff4ae3e
to
f6344de
Compare
@targos this is updated |
LGTM but maybe include what it used to be? It's returning an object instead of.... |
Trott
approved these changes
Jul 26, 2019
I updated the release entry: https://github.com/nodejs/node/releases/tag/v12.7.0 |
LGTM |
lpinca
approved these changes
Jul 27, 2019
This was referenced Jan 16, 2022
This was referenced Jan 17, 2022
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@targos I don't know if it's typical to update this after-the-fact, but here it is in case you want to merge it. I think it's worth drawing attention to, anyway, because it will break people using the experimental "reports" API.