add LTS to releases table #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return callback(err) | ||
| } | ||
|
|
||
| versions.forEach((v) => v.lts === false && delete v.lts) |
There was a problem hiding this comment.
I believe Handlebars.js can ignore false values so no need to delete false property
There was a problem hiding this comment.
no, I added this exactly because it didn't ignore it and I ended up with a bunch of falses in the column
There was a problem hiding this comment.
@rvagg how do you like the {{#if lts}}{{lts}}{{/if}} solution I suggested below?
There was a problem hiding this comment.
sorry, missed it, have updated to use that instead, tbh I didn't know that was possible although I did a quick google for such syntax!
There was a problem hiding this comment.
oh ok :) not saying this is better though.
rvagg
force-pushed
the
lts-in-releases-table
branch
2 times, most recently
from
bc95594
to
7736f29
Compare
|
|
rvagg
force-pushed
the
lts-in-releases-table
branch
from
7736f29
to
d0b113a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.