fix: ensure primary content areas wrapped in main landmark element #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
approved these changes
Oct 15, 2020
|
This should be good to go; I don't see any CSS selectors to break after a quick look. |
SEWeiTung
approved these changes
Feb 17, 2021
|
Thanks for your contribution @jendowns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey everyone! ✨
I noticed that the pages on the site are not wrapped in a
<main>sectioning element, so the goal of this PR is to ensure that each page includes this semantic markup. Including a<main>landmark on a page improves accessibility by helping assistive tech quickly identify the primary content of the page.Additional resources:
mainelementPlease let me know if you have any questions or concerns about this change! Or if I missed a page. 😅