-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive Events Page #378
Conversation
Also, we filter out all the meetups on meetup.com that don't have "node" in the name. That is probably too aggressive but I wanted something a little more manageable to begin with. Eventually we can list every meetup with the "node.js" topic. |
, CA: 'North America' | ||
, US: 'North America' | ||
, AR: 'Latin America' | ||
, PE: 'Latin America' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CO: 'Latin America'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have all of the ones in here that we need for the meetups currently coming out of meetup.com, I wonder why there isn't one showing up for Colombia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like they need to be tagged with the topic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now they need to be tagged with "nodejs" and they need to have "node" in the name, but we may remove that second part later.
Wow, great idea @mikeal 👍 And what a tremendous amount of meetups and nodeschools there are 😃 My initial test displays three entries for |
I have some code that toggles the display of events If people think we should proceed with this I will make it look better and push it up. @mikeal as mentioned previously, looks like the region list is being output three times: |
@rnsloan this already looks so much more manageable. Awesome :) |
@rnsloan suggestion: add some sort of the arrow to the side of those suggesting that they open up. |
If we're going to start with them collapsed we should include some metrics for how many entries, like the number of meetups and nodeschools. |
(also @mikeal can you fix the spelling mistake in the title real quick?) |
Ok, so here's what is left:
|
You did the right thing +1 |
function _bounds () { | ||
for (var i=0;i<points.length;i++) { | ||
var hav = points[i][2] | ||
if (i > 10 && hav > .1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the 10th point the one to return?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's how I do bounds detection, it could be a regular for
loop as well, though where is the fun in that?
function getBounds(points) {
return points.reduce(function(bounds, point) {
bounds.minLat = bounds.minLat < point.lat ? bounds.minLat : point.lat;
bounds.maxLat = bounds.maxLat < point.lat ? point.lat : bounds.maxLat;
bounds.minLon = bounds.minLon < point.lon ? bounds.minLon : point.lon;
bounds.maxLon = bounds.maxLon < point.lon ? point.lon : bounds.maxLon;
return bounds;
}, {minLat: 180, maxLat: -180, minLon: 90, maxLon: -90})
}
Note: events number is hardcoded at this point
Toggling of events lists is in @mikeal can we truncate the text used by the map? Produces a tall box for some like the Melbourne meetup: |
@rnsloan I did a new count in JS so that we can add the totals to the key. The only thing left is some documentation about how to add new events. |
- move inline css into .styl - do not display empty event list number box
Just did a bit of minor cleanup. My code is now ready for review. |
@rnsloan There's no advantage other than we have to do it anyway in order to get the totals and put them in the map key. |
Ok, from my point of view this is ready to be merged, does anyone object? |
Ok, here we go :)
This is code to:
The display is terrible, would love some help there before we merge this.