Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in build.js/copystatic() ENOENT: no such file or directory, open '.../nodejs.org/build/static/event-geo.json' #383

Closed
wants to merge 1 commit into from

Conversation

justsml
Copy link
Contributor

@justsml justsml commented Nov 26, 2015

After I switched to nodejs v5.0, running a clean build no longer worked.
It doesn't seem to be creating the directories before the fs.mkdir callback(s)??

It's a build script, so hopefully a synchronous fix isn't the worst...

@phillipj
Copy link
Member

Strange, not able to reproduce this issue on my machine. What's your OS/version?

@stevemao
Copy link
Contributor

If this was a problem then there might be some issue in the core.

@justsml
Copy link
Contributor Author

justsml commented Nov 27, 2015

I'm on linux mint debian edition v2.
It works on my ubuntu 15.
On my fresh fedora install it works only the 2nd attempt.
I'm migrating to a new HDD tonight, I'll see if that fixes it...

@lpinca
Copy link
Member

lpinca commented Nov 27, 2015

@phillipj @stevemao I'm able to reproduce this and please note that we are on the events branch.

@phillipj
Copy link
Member

If this was a problem then there might be some issue in the core.

Agreed, which probably should be reported.

I wouldn't mind replacing two levels of callbacks with sync here, as it's simpler to grasp and doesn't really matter for performance reasons as @justsml mentioned.

Trying to build with these changes results in an error for me though...

$ npm start

> nodejs.org@1.0.0 start /nodejs.org
> npm run serve


> nodejs.org@1.0.0 serve /nodejs.org
> node build.js serve

fs.js:842
  return binding.mkdir(pathModule._makeLong(path),
                 ^

Error: EEXIST: file already exists, mkdir '/nodejs.org/build'
    at Error (native)
    at Object.fs.mkdirSync (fs.js:842:18)
    at copystatic (/nodejs.org/build.js:175:6)
...

@stevemao
Copy link
Contributor

The problem here is not sync or performance. It's why it fails.

@bnb
Copy link
Contributor

bnb commented Nov 28, 2015

I've started using metalsmith, and got this same error. No idea why it worked, but deleting the existing /build directory solved it.

@mikeal
Copy link
Contributor

mikeal commented Nov 28, 2015

could you re-target to master now that the branch is merged

@mikeal
Copy link
Contributor

mikeal commented Nov 28, 2015

I pushed a hotfix for this just pushing the geo create to before the timer end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants