Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add momentum scrolling #414

Closed
wants to merge 2 commits into from
Closed

add momentum scrolling #414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a5617b
add momentum scrolling
securedledger Dec 9, 2015
20546c5
Update _sticky-footer.styl
moorebrett0 Apr 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions layouts/css/layout/_sticky-footer.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ body
flex-direction column
min-height 100vh
margin 0
overflow-y scroll /* has to be scroll, not auto */
-webkit-overflow-scrolling touch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we using autoprefixer for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the stylus-auto prefixer plugin was installed? Is there anything special I need to do to configure it?

On Dec 9, 2015, at 2:41 PM, Steve Mao notifications@github.com wrote:

In layouts/css/layout/_sticky-footer.styl:

@@ -9,6 +9,8 @@ body
flex-direction column
min-height 100vh
margin 0

  • overflow-y scroll; /* has to be scroll, not auto */
  • -webkit-overflow-scrolling touch
    are we using autoprefixer for this?

—
Reply to this email directly or view it on GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its already configured.

overflow-scrolling touch should just work but its not really standard.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

What's the standard way to turning on the momentum scrolling?    I really do enjoy browsing through the docs on my phone and it's such a pain on my thumb when I have to use it so much to find my spot again (this is the only way I know how :/).

On Dec 9, 2015, at 7:29 PM, Steve Mao notifications@github.com wrote:

In layouts/css/layout/_sticky-footer.styl:

@@ -9,6 +9,8 @@ body
flex-direction column
min-height 100vh
margin 0

  • overflow-y scroll; /* has to be scroll, not auto */
  • -webkit-overflow-scrolling touch
    I think its already configured.

overflow-scrolling touch should just work but its not really standard.

—
Reply to this email directly or view it on GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not saying your doing wrong. I'm saying its not standard feature. https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-overflow-scrolling

And I'm just saying autoprefixer should handle the prefixing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Sorry about that!

On Dec 9, 2015, at 7:56 PM, Steve Mao notifications@github.com wrote:

In layouts/css/layout/_sticky-footer.styl:

@@ -9,6 +9,8 @@ body
flex-direction column
min-height 100vh
margin 0

—
Reply to this email directly or view it on GitHub.


#main
flex 1 0 auto
Expand Down