Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for #449 #455

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Update for #449 #455

merged 1 commit into from
Jan 19, 2016

Conversation

fhemberger
Copy link
Contributor

This PR includes information for both Node.js 4.x and 5.x, as long as --prof-process hasn't been back-ported yet to 4.x.

/cc @Trott @matthewloring


### For Node.js 5.x

Starting Node.js 5.2.2, the the tick processor which is bundled inside the Node.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: "Starting in Node.js 5.2.2, the tick processor is bundled with the Node.js binary and can be run using the --prof-process flag:"

@fhemberger
Copy link
Contributor Author

@matthewloring Updated the PR with your suggestions and removed the headlines again.

@matthewloring
Copy link
Contributor

@fhemberger The changes look good. Hopefully this section will be even simpler once --prof-process is backported into 4.x

@phillipj
Copy link
Member

I'm somewhat confused about this one... Should it be merged instead of #449, or as an addition to it?

@fhemberger
Copy link
Contributor Author

@phillipj Instead. This one contains information for both v4.2 and v5, until the new flag gets backported to v4.2.

@phillipj
Copy link
Member

👍

phillipj added a commit that referenced this pull request Jan 19, 2016
@phillipj phillipj merged commit d3cb851 into master Jan 19, 2016
@phillipj phillipj deleted the content/fix-449 branch January 19, 2016 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants