-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add diagnosis memory leak guide #4590
Conversation
cc @nodejs/diagnostics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the initial idea of the diagnostics working group was to add those guides in https://github.com/nodejs/diagnostics to then elaborate a long guide to nodejs.org.
I feel we need to discuss it. What do you think?
I recommend you add it to the next diag-agenda. cc: @nodejs/diagnostics
EDIT1: I mean, I feel this guide would fit perfectly in: https://github.com/nodejs/diagnostics/tree/main/documentation/memory
Hey @RafaelGSS 👋 Sorry, I was off the past week so I didn't answer quickly.
This issue is still in the agenda we could discuss it at the next meeting 🙌 My only concern about keeping stuff in diag repo is that visibility/accessibility is limited. I'd like to expose each piece of the puzzle as soon as it's ready. |
As discussed in the last diagnostics WG meeting, we'll close this issue and merge the content into the diagnostic repository. |
Hi Node Familly 👋
Context
The Diagnostic Working Group started an initiative to re-assess the diagnostics tools list.
I start to work around the
--trace-gc
flag:trace_gc
to diagnostic tooling support document node#42346--trace-gc
flag test node#42471But something is missing... 😞
If you take a look at the diagnostic tooling support tiers, you'll see that:
Added
I propose to add a new guide to the existing collection 🆕.
The guide is about how could we use built-in tools to diagnose memory leaks.
Here is a list of topics I hope this guide will help on:
--trace-gc
? and how could we interpret the output?Concern