Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contributing): updated fast-tracking rules #5206

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Mar 28, 2023

This PR updates some of the Pull Request review policies by patching the rule of what can be immediately merged and adding an explicit "fast-tracking" rule.

As this PR changes governing rules for this repository, at least 2 or more members need to approve this PR, and no objection should've done during the meantime (48hours).

cc @nodejs/website

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@ovflowd ovflowd requested a review from a team as a code owner March 28, 2023 08:28
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member Author

ovflowd commented Mar 28, 2023

FYII, @AugustinMauroy I appreciate your LGTM but only approvals from the Website team will be counted. (Since this changes the team policies)

CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@ovflowd ovflowd merged commit 48e41c6 into main Mar 29, 2023
@ovflowd ovflowd deleted the chore/fast-tracking branch March 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants