Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Improve the TRANSLATION.md #5232

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

SEWeiTung
Copy link
Contributor

The introduction of TRANSLATION.md for Crowdin is a bit too simple to understand, especially for a newbie who wants to join in the group and how to get started. Here I've given some very useful links to guide them step-by-step on how to cope with Crowdin and join in the translating group together to make contributions to nodejs.org.

Several changes:

  1. Rename 'Crowdin' to 'Nodejs-website in Crowin', because this is a nodejs-website based Crowdin project.

  2. Add more step-by-step guides to bring you to the home of Crowdin and join in it without problems to get started quickly.

  3. For any discussions related to our previous discussion at Some Suggestions and Questions on Localizations' changes #5222 (reply in thread) and Some Suggestions and Questions on Localizations' changes #5222 (reply in thread), we'd better include such info to let volunteers get to know how to have discussions/chats in Crowdin instead of in GitHub.

The introduction of TRANSLATION.md for Crowdin is a bit too simple to understand, especially for a newbie who wants to join in the group and how to get started. Here I've given some very useful links to guide them step-by-step on how to cope with Crowdin and join in the translating group together to make contributions to nodejs.org.

Several changes:

1. Rename 'Crowdin' to 'Nodejs-website in Crowin', because this is a nodejs-website based Crowdin project.

2. Add more step-by-step guides to bring you to the home of Crowdin and join in it without problems to get started quickly.

Signed-off-by: Wai.Tung <maledong_public@foxmail.com>
@SEWeiTung SEWeiTung requested a review from a team as a code owner April 5, 2023 07:10
@SEWeiTung
Copy link
Contributor Author

I'm a newbie to bother others about Crowdin, and I don't like others bothering and questioning here and there, that's the reason why I want to improve this article, hope most frequently-asked questions can be solved here :)

TRANSLATION.md Outdated Show resolved Hide resolved
fix according to @Trott 's review

Signed-off-by: Wai.Tung <maledong_public@foxmail.com>
TRANSLATION.md Outdated Show resolved Hide resolved
Oh, many thanks! This is more suitable.

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Wai.Tung <maledong_public@foxmail.com>
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for updating the docs, @MaledongGit!

@ovflowd ovflowd merged commit f1df7cc into main Apr 7, 2023
@ovflowd ovflowd deleted the improveTranslationWithCrowdin branch April 7, 2023 10:05
araujogui pushed a commit to araujogui/nodejs.org that referenced this pull request Apr 14, 2023
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants