chore: vercel enable middleware and i18n redirection #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It looks like there's an issue on Vercel's side regarding the failed Storybook deployment (https://github.com/orgs/vercel/discussions/1321) |
|
Does this code snippet remove |
No. Otherwise, I would have replaced the Component 😉 |
|
Good news! Vercel CLI 29.1.1 has been released with support for Storybook projects! The Storybook framework can now be selected under the project settings. Please update your CLI, then update your project's framework and you should be good to go. Cheers! |
|
Thank you @cb1kenobi this is fantastic! |
|
Hey @nodejs/website could I get some reviews here? |
ovflowd
force-pushed
the
major/website-redesign
branch
from
7ddfa8d
to
f2a3ac4
Compare
HinataKah0
approved these changes
May 4, 2023
There was a problem hiding this comment.
LGTM!
I tried playing around with it too, and it seems fine.
Left 1 unblocking nitpick.
ovflowd
added a commit
that referenced
this pull request
May 14, 2023
* feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore(minor): just a tiny design nitpick * chore: set up storybook (#5191) (#5214) * chore: set up testing-library jest extend (#5231) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> * chore(dependencies): updated dependencies * feat: create section title component (#5237) Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * 📎 chore(migration): migrate banner component (#5233) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat: migrate AnimatedPlaceholder component (#5238 Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story. * feat: create article alert component (#5243) * feat: migrate blockquote component (#5259) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat: create article data tag component (#5280) * feat: migrate AuthorList component and add story 🎉 (#5277) Co-authored-by: Michael Esteban <mickel13@gmail.com> * chore(migration): migrate language selector component (#5266) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> * chore: contributing quick fix of example Signed-off-by: Claudio Wunder <cwunder@gnome.org> * chore: story guide and react spreading Signed-off-by: Claudio Wunder <cwunder@gnome.org> * chore: remove base styles from old styling * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * fix(package.json) Lint command is missing slashes (#5321 fix(package.json) lint:fix missing slashes * moved `DataTag` to `components/Api` (#5317) Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> * hot-fix: dependency updates and fix dev runtime * chore: updated start command * migration(Layout): newFooter (#5320) Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat: migrate EditLink component (#5271) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * feat(blog) Migrate BlogCard component (#5323) Co-authored-by: Michael Esteban <mickel13@gmail.com> * Issue#5307 - Add framer-motion to the dependency list (#5318) * chore: add remote turbo cache and simplified gh actions cache (#5326)Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> * chore: add remote turbo cache and simplified gh actions cache * chore: updated cache rules * chore: more cache rules --------- Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> * chore: fix storybook local development mode (#5335) * chore: migrate pagination component (#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * Chore(node feat) (#5338) Co-authored-by: Claudio Wunder <cwunder@gnome.org> * chore: migrate releases types (#5324) * hotfix: first element no margin-top * (website redesign) Feat(shellbox): migration (#5234) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * fix(i18n): translation key (#5347) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * chore: updated dependencies * chore: vercel enable middleware and i18n redirection (#5300) * feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore: set up storybook (#5191) (#5214) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * feat(stability): migrate component * chore(snapshot): update * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fea(stability): update stories + fix * Update components/Api/Stability/index.stories.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix(i18n): update turkish language direction (#5182) * chore: rollback CODEOWNER changes (#5183) * Sync: merge `major/website-redesign` into `main` (#5356) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com> Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com> Co-authored-by: Floran Hachez <floran.hachez@gmail.com> Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com> * feat(stability): update snapshot * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * code format * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> --------- Signed-off-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com> Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com> Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Floran Hachez <floran.hachez@gmail.com> Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
middlewarethat will take on i18n Language Detection (through theAccepted-LanguageHeader.This is an SSR-exclusive feature and does not affect the static builds. When using Static Generation, the Middlewares will be ignored. The codebase is still designed in a way to be entirely static compatible.
This PR also introduces an
optimizedImage Loader (that also requires SSR). This change requires SSR but can easily be disabled by setting the config fromfalsetotrue(for the image.unoptimized key).