Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adopt @nodevu/core and remove node-version-data #5332

Merged
merged 3 commits into from
May 3, 2023
Merged

chore: adopt @nodevu/core and remove node-version-data #5332

merged 3 commits into from
May 3, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Apr 26, 2023

This PR removes the outdated node-version-data package in favour of using modern Node APIS (@nodevu).

The package is maintained by @bnb and is getting into @pkgjs (if I recall correctly).

This also fixes some of the issues we have with the current library.

@ovflowd ovflowd added the infrastructure Issues/PRs related to the Repository Infra label Apr 26, 2023
@ovflowd ovflowd requested a review from a team as a code owner April 26, 2023 15:10
@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nodejs-org ⬜️ Ignored (Inspect) May 2, 2023 8:15am
nodejs-org-stories ⬜️ Ignored (Inspect) May 2, 2023 8:15am

@tniessen
Copy link
Member

This also fixes some of the issues we have with the current library.

Could you elaborate on said issues?

@ovflowd
Copy link
Member Author

ovflowd commented Apr 26, 2023

Could you elaborate on said issues?

  • Being CommonJS whilst the remaining codebase of Node.js org ESM
  • Being slow (relatively compared to @nodevu
  • Unmaintained
  • When API requests fails there's a break of API (without throwing errors) causing unrelated issues within the build of the Website

@richardlau
Copy link
Member

This PR removes the outdated node-version-data package in favour of using modern Node APIS (@nodevu).

Are you using anything from that that isn't covered by https://github.com/pkgjs/nv?

@ovflowd
Copy link
Member Author

ovflowd commented Apr 26, 2023

Ye, such as dependencies (npm) and their versions.

The proposed package also has an elegant way of showing some meta information like support information (is security release, lts release) what are the latest security releases for a given major and many other metadata that can definitely be helpful in the future.

next.config.mjs Outdated Show resolved Hide resolved
@ovflowd
Copy link
Member Author

ovflowd commented Apr 30, 2023

@richardlau @tniessen are you folks OK with the change?

cc @nodejs/website for approvals / review

@ovflowd ovflowd requested a review from mikeesto April 30, 2023 09:25
@ovflowd
Copy link
Member Author

ovflowd commented May 2, 2023

A friendly bump @nodejs/website

Copy link
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cookie Monster

@ovflowd
Copy link
Member Author

ovflowd commented May 2, 2023

Ty @benhalverson, glad to see you around 🙇 ❤️

@aymen94 aymen94 merged commit a680f97 into nodejs:main May 3, 2023
@ovflowd ovflowd deleted the chore/adopt-nodevu-core branch May 3, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues/PRs related to the Repository Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants