Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: no-unused-vars ignores pattern starting with _ #5363

Merged
merged 1 commit into from
May 11, 2023
Merged

chore: no-unused-vars ignores pattern starting with _ #5363

merged 1 commit into from
May 11, 2023

Conversation

HinataKah0
Copy link
Contributor

See https://eslint.org/docs/latest/rules/no-unused-vars#argsignorepattern

Declaring function signature type, e.g. (name: string) => void, upsets ESLint. This commit will add rule to ignore pattern starting with _, so you can declare it (_name: string) => void.

@vercel
Copy link

vercel bot commented May 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 11:54am
nodejs-org-stories ✅ Ready (Inspect) Visit Preview May 10, 2023 11:54am

@vercel vercel bot temporarily deployed to Preview – nodejs-org May 7, 2023 14:02 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 7, 2023 14:03 Inactive
@HinataKah0 HinataKah0 force-pushed the chore/no-unused-vars-ignores-underscore branch from d2874b8 to 83e3472 Compare May 7, 2023 14:08
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 7, 2023 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 7, 2023 14:09 Inactive
@HinataKah0
Copy link
Contributor Author

HinataKah0 commented May 7, 2023 •
edited
Loading

Cherry-picked from #5341
Let's get this merged so it doesn't block others.

@HinataKah0 HinataKah0 marked this pull request as draft May 7, 2023 14:20
@HinataKah0
Copy link
Contributor Author

HinataKah0 commented May 7, 2023 •
edited
Loading

Ah, the rule is added to the wrong place. It doesn't cover *.ts file. I'll fix it tomorrow.

@HinataKah0 HinataKah0 force-pushed the chore/no-unused-vars-ignores-underscore branch from 83e3472 to 1874539 Compare May 8, 2023 01:14
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 8, 2023 01:15 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 8, 2023 01:16 Inactive
@HinataKah0 HinataKah0 marked this pull request as ready for review May 8, 2023 01:17
@mikeesto
Copy link
Member

mikeesto commented May 9, 2023

Hi @HinataKah0 . I'm keen to merge this but your commit is not signed, and we have a ruleset that requires all commits to be signed. I had a quick look at some of your other open PRs and it's a similar problem there as well.

Could you please have a look into this for me? I'm not sure exactly what your workflow is. However, there is some information here that may help: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@HinataKah0
chore: no-unused-vars ignores pattern starting with _
0091386 
See https://eslint.org/docs/latest/rules/no-unused-vars#argsignorepattern

Declaring function signature type, e.g. (name: string) => void,
upsets ESLint. This commit will add rule to ignore pattern
starting with _, so you can declare it (_name: string) => void.
@HinataKah0 HinataKah0 force-pushed the chore/no-unused-vars-ignores-underscore branch from 1874539 to 0091386 Compare May 10, 2023 11:53
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 10, 2023 11:53 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 10, 2023 11:54 Inactive
@HinataKah0
Copy link
Contributor Author

@mikeesto Just signed my commit

However, I saw this:

Merging is blocked
The base branch does not allow updates.

Not sure how we normally proceed?

@AugustinMauroy
Copy link
Member

Because you are not a member of org ?

@HinataKah0
Copy link
Contributor Author

It seems there's an option to bypass but red text always scares me 🙈

@AugustinMauroy
Copy link
Member

You cannot merge an pr if you are not in website team.

@mikeesto
Copy link
Member

mikeesto commented May 10, 2023 •
edited
Loading

@HinataKah0 Thanks, the commit looks good now. Not sure why merging is blocked - I haven't seen that before. Will try to find out. Claudio updated the ruleset for us.

@mikeesto mikeesto merged commit c526a02 into nodejs:major/website-redesign May 11, 2023
@ovflowd
Copy link
Member

ovflowd commented May 11, 2023

@AugustinMauroy, @HinataKah0 is on the team, the "issue" was a security ruleset. Already fixed it, thanks for reporting @mikeesto

@HinataKah0 HinataKah0 deleted the chore/no-unused-vars-ignores-underscore branch May 14, 2023 09:32
ovflowd added a commit that referenced this pull request May 17, 2023
@ovflowd @Harkunwar
@manishprivet @SEWeiTung @shanpriyan @mikeesto @aymen94 @AugustinMauroy @araujogui @HinataKah0 @Olaleye-Blessing @ktssr @vasanth9 @FHachez @JatinSharma32 @Ve33y @mertcanaltin
chore: updates main with latest major/website-redesign (#5382)
2065bf7 
* test(snapshot): Migrate snapshot tests to storybook (#5340)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
fixed styleling misconfig and fixed storybooks (#5281)
fix storybook styles, imports, typescript config and dependencies (#5319
fix(package.json) Lint command is missing slashes (#5321
fix storybook local development mode (#5335)
fix(i18n): translation key (#5347)

* chore: no-unused-vars ignores pattern starting with _ (#5363)

* Contributing Guidelines Update - Add clarity to step 4 based on clone method (#5369)

Add clarity to step 4 based on clone method

Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>

* fix(test): dir name (#5354)

* feat(stability): migrate component (#5339)

* Migrate JsonLink component (#5370)

* Migrate JsonLink component

Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>

* Add storybook snap and robot icon

Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>

* Remove IconContext provider

Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>

---------

Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376)

* refactor(useDownloadLink): Move useDetectOs to useDownloadLink

* refactor(useDownloadLink): rename file

* refactor(useDownloadLink): rename file

* Apply suggestions from code review

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

* refactor(useDownloadLink): undo deleted file

---------

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat: Add MUI Config and Theme Provider (#5368)

* feat: Add MUI Config and Theme Provider

* added createTheme

* refactor themeConfig

* feat(theme): Fix linting and package-lock

* feat(theme): Add emotion styled and emtion react

---------

Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>

* refactor(delete): duplicate test file (#5377)

refactor(test): Delete duplicate test file

Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat(useClickOutside): introduce (#5359)

* feat(useClickOutside): introduce

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* feat(useClickOutside): fix and twix

* feat(dropdown): remove useless ref

* feat(useClickOutside): update unit test

* feat(UseClickOutside): update type

* fix: usage of type

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* update listener

* Update components/Common/LanguageSelector/index.tsx

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* fix: languageSelector

* update with feedback

* better unit test

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* feat(useClickOutside): update with feedback

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* fix: if click on modal

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* Update hooks/useClickOutside.ts

Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* Update useClickOutside.ts

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* Update useClickOutside.ts

* Apply suggestions from code review

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* fix: build

---------

Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>

---------

Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
Co-authored-by: Vessy <46304479+Ve33y@users.noreply.github.com>
Co-authored-by: Mert Can Altın <mertgold60@gmail.com>
ovflowd pushed a commit that referenced this pull request May 24, 2023
@HinataKah0 @ovflowd
chore: no-unused-vars ignores pattern starting with _ (#5363)
8676bb1
ovflowd pushed a commit that referenced this pull request May 24, 2023
@HinataKah0 @ovflowd
chore: no-unused-vars ignores pattern starting with _ (#5363)
f52ef56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEWeiTung SEWeiTung SEWeiTung approved these changes

@aymen94 aymen94 aymen94 approved these changes

@Harkunwar Harkunwar Harkunwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HinataKah0 @mikeesto @AugustinMauroy @ovflowd @Harkunwar @aymen94 @SEWeiTung