Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed the order of sections in CONTRIBUTING.md #5394

Merged
merged 1 commit into from
May 23, 2023
Merged

docs: fixed the order of sections in CONTRIBUTING.md #5394

merged 1 commit into from
May 23, 2023

Conversation

Basa198
Copy link
Contributor

@Basa198 Basa198 commented May 23, 2023

Description

Just moved the Vocabulary section to the top of Getting started section to align with the table of contents:

image

Related Issues

Ref: #5393

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@Basa198 Basa198 requested a review from a team as a code owner May 23, 2023 13:47
@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org-stories ✅ Ready (Inspect) Visit Preview May 23, 2023 1:48pm

@vercel
Copy link

vercel bot commented May 23, 2023

@runday198 is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 23, 2023 13:48 Inactive
Copy link
Contributor

@HinataKah0 HinataKah0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the first time contribution!
LGTM

I think it should be okay to move it up because it doesn't make sense anyway if it is located very far at the bottom :)

@aymen94
Copy link
Member

aymen94 commented May 23, 2023

LGTM 😃 and congrats for the first contribution!

@ovflowd ovflowd merged commit 275c3dc into nodejs:main May 23, 2023
@Basa198
Copy link
Contributor Author

Basa198 commented May 23, 2023

Thanks a lot, will continue to contribute as much as I can ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants