Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gnu tar for unzipping cache files on windows #5414

Merged
merged 6 commits into from
Jun 2, 2023
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented May 31, 2023

This PR simply adopts GNU tar for Windows runs as the default tar unzip strategy is super slow.

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 31, 2023 15:36 Inactive
@ovflowd ovflowd requested a review from a team as a code owner May 31, 2023 15:36
@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 4:01pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview May 31, 2023 4:01pm

@ovflowd ovflowd changed the title chore: gnu tar chore: gnu tar for unzipping cache files on windows May 31, 2023
@ovflowd
Copy link
Member Author

ovflowd commented May 31, 2023

FYI: I've only made this PR to see how faster each PR run becomes.

@vercel vercel bot temporarily deployed to Preview – nodejs-org May 31, 2023 15:36 Inactive
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 31, 2023 15:50 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 31, 2023 15:50 Inactive
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 31, 2023 15:52 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 31, 2023 15:52 Inactive
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 31, 2023 15:55 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 31, 2023 15:55 Inactive
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 31, 2023 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 31, 2023 15:58 Inactive
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 31, 2023 16:01 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 31, 2023 16:01 Inactive
@ovflowd
Copy link
Member Author

ovflowd commented May 31, 2023

cc @nodejs/website as this PR became more complex I want at least approvals from someone of the team :)

Seems that these changes are making the pipelines faster :yay:

@ovflowd
Copy link
Member Author

ovflowd commented Jun 1, 2023

cc @nodejs/website for reviews :)

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh waw that good code !

Copy link
Contributor

@HinataKah0 HinataKah0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/pull-request.yml Show resolved Hide resolved
@ovflowd ovflowd merged commit 2d8d205 into main Jun 2, 2023
@ovflowd ovflowd deleted the chore/use-gnu-tar branch June 2, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants