Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add pos announcement sec release #5447

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

RafaelGSS
Copy link
Member

No description provided.

@RafaelGSS RafaelGSS requested a review from a team as a code owner June 20, 2023 20:36
@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 9:12pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 9:12pm

@vercel
Copy link

vercel bot commented Jun 20, 2023

@RafaelGSS is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 20, 2023 20:37 Inactive
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS enabled auto-merge (squash) June 20, 2023 20:39
@RafaelGSS RafaelGSS disabled auto-merge June 20, 2023 20:39
@RafaelGSS RafaelGSS enabled auto-merge (squash) June 20, 2023 20:47
@RafaelGSS RafaelGSS disabled auto-merge June 20, 2023 20:48
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 20, 2023 20:48 Inactive
@RafaelGSS RafaelGSS merged commit 87ed672 into nodejs:main Jun 20, 2023
@ovflowd
Copy link
Member

ovflowd commented Jun 20, 2023

Note that since we're merging so many things concurrently, the WebHook on our server will ignore all consecutive merges if a build is already happening. It is a known bug.

After the build finishes (10m maybe?) I'm going to retrigger the WebHook.

@Trott
Copy link
Member

Trott commented Jun 20, 2023

Note that since we're merging so many things concurrently, the WebHook on our server will ignore all consecutive merges if a build is already happening. It is a known bug.

After the build finishes (10m maybe?) I'm going to retrigger the WebHook.

I just pressed the Redelivery button for it.

@vercel vercel bot temporarily deployed to Preview – nodejs-org June 20, 2023 21:11 Inactive
@Trott
Copy link
Member

Trott commented Jun 20, 2023

I just pressed the Redelivery button for it.

Still not showing up, though, so maybe I did it wrong? @ovflowd

@ovflowd
Copy link
Member

ovflowd commented Jun 20, 2023

As I mentioned we need to wait enough tike for any running build inside the server to finish. It ignores new deliveries until the currently running one hasn't finished.

@ovflowd
Copy link
Member

ovflowd commented Jun 20, 2023

Deployed with success!

@Trott
Copy link
Member

Trott commented Jun 20, 2023

As I mentioned we need to wait enough tike for any running build inside the server to finish. It ignores new deliveries until the currently running one hasn't finished.

I thought it had finished, but I guess I was wrong. Ah well. Thank you for making it happen!

@ovflowd
Copy link
Member

ovflowd commented Jun 20, 2023

No worries!! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants