-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: main download button for linux incorrect #5618
Conversation
Signed-off-by: Stewart X Addison <sxa@redhat.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for nodejs.orgThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks legit to me :) (Feel free to test on the Deployment Preview URL)
Preview looks good. Note that this is currently hard coded to provide the Linux/x64 download when a Linux web browser is detected, however this is consistent with the label displayed above the buttons which will always display (X64) for the architecture as per nodejs.org/layouts/IndexLayout.tsx Line 17 in 562ed48
The architecture detection would require more work so this should be considered a first phase of the solution. |
Yeah, we have plans of better arch detection, the main reason it is the way it is is because in the past only these 3 platforms were considered. On the redesigns we're aiming for a broader range. |
I'm fast-tracking this due to the nature of being a super simple change. |
Description
Fixes #5610 - the download button for Linux on the front page of the website links to the source tar archive, not the built node.js for that platform as it should.
Validation
Main download link is for the binary, not the source, when connecting from a Linux web browser.
Related Issues
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing, and/ornpx turbo test:snapshot
to update snapshots if I created and/or updated React Components.