Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update notable changes in v21.1.0 #6045

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

joyeecheung
Copy link
Member

Refs: nodejs/node#50335 (comment)

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

Refs: nodejs/node#50335 (comment)

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung joyeecheung requested a review from a team as a code owner October 24, 2023 17:44
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 5:49pm

@joyeecheung joyeecheung changed the title update notable changes in v21.1.0 fix: update notable changes in v21.1.0 Oct 24, 2023
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to update the release notes on github as well.

@joyeecheung
Copy link
Member Author

joyeecheung commented Oct 25, 2023

What's blocking the tests to complete?

@ovflowd
Copy link
Member

ovflowd commented Oct 25, 2023

What's blocking the tests to complete?

CI needs to be triggered by a label. I think that is mentioned on the releasers documentation.

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
94.61% (281/297) 76.81% (53/69) 93.33% (56/60)

Unit Test Report

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 7.659s ⏱️

@joyeecheung joyeecheung added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 4cfd688 Oct 25, 2023
14 checks passed
@joyeecheung joyeecheung deleted the joyeecheung-patch-1 branch October 25, 2023 09:20
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Oct 26, 2023
PR-URL: #50388
Refs: nodejs/nodejs.org#6045
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50388
Refs: nodejs/nodejs.org#6045
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Nov 11, 2023
PR-URL: #50388
Refs: nodejs/nodejs.org#6045
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to nodejs/node that referenced this pull request Dec 11, 2023
PR-URL: #50388
Refs: nodejs/nodejs.org#6045
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to nodejs/node that referenced this pull request Dec 13, 2023
PR-URL: #50388
Refs: nodejs/nodejs.org#6045
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to nodejs/node that referenced this pull request Dec 15, 2023
PR-URL: #50388
Refs: nodejs/nodejs.org#6045
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to nodejs/node that referenced this pull request Dec 19, 2023
PR-URL: #50388
Refs: nodejs/nodejs.org#6045
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants