Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: layout locations and code styling updates #6098

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

canerakdas
Copy link
Member

Description

This pull request includes the review updates in the link below;
#6092 (review)

Validation

In Preview, ensure the sitemap works correctly and the pages working as expected

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested a review from a team as a code owner November 8, 2023 14:48
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 2:49pm

Copy link

github-actions bot commented Nov 8, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 97 🟢 92 🟢 92 🔗

Copy link

github-actions bot commented Nov 8, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
79.1% (352/445) 63.46% (66/104) 62.22% (56/90)

Unit Test Report

Tests Skipped Failures Errors Time
54 0 💤 0 ❌ 0 🔥 7.275s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Nov 9, 2023

cc @nodejs/nodejs-website I'm fast tracking this as trivial changes

@ovflowd ovflowd added this pull request to the merge queue Nov 9, 2023
Merged via the queue into nodejs:main with commit 20cc909 Nov 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants