-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sentry #6099
feat: sentry #6099
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
cc @nodejs/web-infra for review and approval ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
i din't use a lot sentry but it's great tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really excited for this!
In addition to my comments, can you also add to https://github.com/nodejs/nodejs.org/blob/main/COLLABORATOR_GUIDE.md#technologies-used-in-the-website perhaps?
Not relevant IMO. At least not to your average collaborator. |
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Claudio W <cwunder@gnome.org>
cc @bmuenzenmeyer can you give an approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great - dont really have a good way to test this so 🤞
we can always hotfix if something is messed up
cc @nodejs/web-infra let's get this merged as it's always great to have monitoring. |
Description
Introduces Sentry to the Node.js Website (Server-side, Edge-functions and Client-side)