Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: locale and layouts errors #6134

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix: locale and layouts errors #6134

merged 2 commits into from
Nov 21, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 21, 2023

Description

This PR fixes a pesky Sentry issue by moving the not-found and root layout to under [locale] folder

@ovflowd ovflowd added fast-track Fast Tracking PRs infrastructure Issues/PRs related to the Repository Infra labels Nov 21, 2023
@ovflowd ovflowd requested a review from a team as a code owner November 21, 2023 22:41
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2023
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 10:52pm

Copy link

github-actions bot commented Nov 21, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 97 🟠 83 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟠 83 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟠 83 🟢 92 🔗
/en/blog 🟢 99 🟢 97 🟠 83 🟢 92 🔗

Copy link

github-actions bot commented Nov 21, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 87%
82.91% (398/480) 70.16% (87/124) 69.14% (65/94)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 5.525s ⏱️

@ovflowd ovflowd requested a review from a team as a code owner November 21, 2023 22:51
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2023
@ovflowd ovflowd merged commit 5f56779 into main Nov 21, 2023
15 checks passed
@ovflowd ovflowd deleted the fix/locale-layout-errors branch November 21, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs infrastructure Issues/PRs related to the Repository Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant