Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: v20.10.0 release post #6135

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Blog: v20.10.0 release post #6135

merged 1 commit into from
Nov 22, 2023

Conversation

targos
Copy link
Member

@targos targos commented Nov 22, 2023

@targos targos requested a review from a team as a code owner November 22, 2023 15:30
Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 3:32pm

Copy link

github-actions bot commented Nov 22, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 97 🟠 83 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 87%
82.91% (398/480) 70.16% (87/124) 69.14% (65/94)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 5.431s ⏱️

@targos
Copy link
Member Author

targos commented Nov 22, 2023

I have no idea what's making the build fail.

Error:

- info (blog-posts-data.json) and (node-releases-data.json) got generated.
  undefined:710
  {"version":"v0.1.18","date":"2011-08-26",
  
  SyntaxError: Expected double-quoted property name in JSON at position 263[21](https://github.com/nodejs/nodejs.org/actions/runs/6959448441/job/18936701109?pr=6135#step:7:22)6
      at JSON.parse (<anonymous>)
      at parseJSONFromBytes (node:internal/deps/undici/undici:4553:19)
      at successSteps (node:internal/deps/undici/undici:4527:27)
      at fullyReadBody (node:internal/deps/undici/undici:1307:9)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async specConsumeBody (node:internal/deps/undici/undici:4536:7)
      at async core (/home/runner/work/nodejs.org/nodejs.org/node_modules/@nodevu/core/index.js:18:20)
      at async Module.generateNodeReleasesJson (file:///home/runner/work/nodejs.org/nodejs.org/next-data/generateNodeReleasesJson.mjs:33:[24](https://github.com/nodejs/nodejs.org/actions/runs/6959448441/job/18936701109?pr=6135#step:7:25))
      at async file:///home/runner/work/nodejs.org/nodejs.org/scripts/generate-next-data/index.mjs:11:1
  
  Node.js v20.9.0

@targos targos added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@richardlau
Copy link
Member

richardlau commented Nov 22, 2023

I have no idea what's making the build fail.

I reran the failing build and it passed. I assume it downloads index.json and hit an issue while the download server is overwhelmed.

@richardlau richardlau added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@richardlau richardlau added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@richardlau
Copy link
Member

I have no idea what's making the build fail.

I reran the failing build and it passed. I assume it downloads index.json and hit an issue while the download server is overwhelmed.

Looks like it's failing when run for the merge queue as well 😞.

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Nov 22, 2023

I'm looking into the build error but it's can from #6136 . I'm testing on my machine
EDIT: yes it's form that

@ovflowd
Copy link
Member

ovflowd commented Nov 22, 2023

I'm looking into the build error but it's can from #6136 . I'm testing on my machine

There's nothing wrong, Augustin. Just the DO server being overwhelmed.

@richardlau richardlau added this pull request to the merge queue Nov 22, 2023
Merged via the queue into nodejs:main with commit 90af0b5 Nov 22, 2023
13 checks passed
@targos targos deleted the v20.10.0 branch November 22, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants