Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] Apply security best practices #6142

Merged

Conversation

step-security-bot
Copy link
Contributor

Summary

This pull request is created by StepSecurity at the request of @ovflowd. Please merge the Pull Request to incorporate the requested changes. Please tag @ovflowd on your message if you have any questions related to the PR.

Security Fixes

Harden Runner

Harden-Runner is an open-source security agent for the GitHub-hosted runner to prevent software supply chain attacks. It prevents exfiltration of credentials, detects tampering of source code during build, and enables running jobs without sudo access.

Harden runner usage

You can find link to view insights and policy recommendation in the build log

Please refer to documentation to find more details.

Detect Vulnerabilities with SAST Workflow

Static Code Analysis (also known as Source Code Analysis) is usually performed as part of a Code Review (also known as clear-box testing) and is carried out at the Implementation phase of a Security Development Lifecycle (SDL). Static Code Analysis commonly refers to the running of Static Code Analysis tools that attempt to highlight possible vulnerabilities within ‘static’ (non-running) source code by using techniques such as Taint Analysis and Data Flow Analysis.

Maintain Code Quality with Pre-Commit

Pre-commit is a framework for managing and maintaining multi-language pre-commit hooks. Hooks can be any scripts, code, or binaries that run at any stage of the git workflow. Pre-commit hooks are useful for enforcing code quality, code formatting, and detecting security vulnerabilities.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

@step-security-bot step-security-bot requested review from a team as code owners November 25, 2023 11:48
Copy link

vercel bot commented Nov 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 0:38am

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
@ovflowd ovflowd force-pushed the stepsecurity_remediation_1700912929 branch from ebace34 to 57a819e Compare November 25, 2023 12:14
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 25, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 25, 2023
Copy link
Contributor

github-actions bot commented Nov 25, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟠 83 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/blog 🟢 95 🟢 95 🟢 92 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Nov 25, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
90.61% (367/405) 77.5% (93/120) 89.18% (66/74)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 5.374s ⏱️

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ovflowd
Copy link
Member

ovflowd commented Nov 25, 2023

cc @nodejs/web-infra @nodejs/security I'm merging this as a recommendation from the OpenSSF Scorecard and StepSecurity. Please feel free to review this after-merge-

cc @ljharb @UlisesGascon

@ovflowd ovflowd merged commit dec347f into nodejs:main Nov 25, 2023
@ovflowd
Copy link
Member

ovflowd commented Nov 25, 2023

(Forcing a merge of this as a Security Fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants