Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better examples on home #6457

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Mar 6, 2024

This PR simply updates some examples to keep them easier to understand and easier to run/reproduce

@ovflowd ovflowd requested a review from a team as a code owner March 6, 2024 14:26
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 7, 2024 5:55pm

Copy link

github-actions bot commented Mar 6, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 90 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 91 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 90 🟢 100 🟢 92 🔗

Copy link

github-actions bot commented Mar 6, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
80.03% (449/561) 79.55% (144/181) 71.17% (79/111)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 4.433s ⏱️

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the file names, thoughts on just have // <name>.mjs at the top of the file, and then // Run with 'node <name>.mjs' at the end of the file?

I think that feels a bit cleaner to me, and flows with the user journey of creating/reading the file, and then running it?

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome to see you acheived better content while balancing the heights of all of them

small suggestion within, not blocking

pages/en/index.mdx Outdated Show resolved Hide resolved
pages/en/index.mdx Show resolved Hide resolved
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Mar 8, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 8, 2024
@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit ec7ec38 Mar 8, 2024
14 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the fix/improved-examples-on-home branch March 8, 2024 03:40
@ovflowd
Copy link
Member Author

ovflowd commented Mar 8, 2024

For the file names, thoughts on just have // <name>.mjs at the top of the file, and then // Run with 'node <name>.mjs' at the end of the file?

I think that feels a bit cleaner to me, and flows with the user journey of creating/reading the file, and then running it?

I saw this got ignored? @MattIPv4 feel free to make a PR! I was busy these days 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants