-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better examples on home #6457
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the file names, thoughts on just have // <name>.mjs
at the top of the file, and then // Run with 'node <name>.mjs'
at the end of the file?
I think that feels a bit cleaner to me, and flows with the user journey of creating/reading the file, and then running it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome to see you acheived better content while balancing the heights of all of them
small suggestion within, not blocking
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
I saw this got ignored? @MattIPv4 feel free to make a PR! I was busy these days 🥲 |
This PR simply updates some examples to keep them easier to understand and easier to run/reproduce