Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(download): Add APT and YUM package manager #6502

Closed
wants to merge 1 commit into from

Conversation

riosje
Copy link

@riosje riosje commented Mar 21, 2024

Add APT and YUM package manager

Hello Node.js Team,

I hope this message finds you well. This PR is to propose the inclusion of APT and YUM installation instructions for Node.js on the official Node.js Downloads page.
These package managers are the default for Debian/Ubuntu and RHEL-based systems and are familiar to a vast number of users.

Why should nodejs.org need those?

  • Improves accessibility and user experience for Linux users.
  • Encourages best practices through trusted and maintained channels.
  • Aligns with community usage patterns and expectations.
  • Nodesource APT and RPM packages are widely used by the community and we have millions of downloads per month.

I am ready to contribute the necessary instructions and collaborate on refining the content to meet the Node.js website standards.

Validation

You can visit the repo where this is maintained, the installation instructions are really straight forward.
https://github.com/nodesource/distributions

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Jefferson <jefferson.rios.caro@gmail.com>

feat(download): Add APT and YUM package manager
@riosje riosje requested a review from a team as a code owner March 21, 2024 12:51
Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 21, 2024 0:53am

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APT and YUM are not Node package managers.

@ovflowd
Copy link
Member

ovflowd commented Mar 21, 2024

To make this clear, we are not going to land this. Sorry.

We already limited the amount of package managers to a very subset of things we can somewhat have control or influence over.

Adding Distribution package managers here is a no go and are not official ways of installing Node.js and often the biggest source of issues for Node.js installations.

@ovflowd
Copy link
Member

ovflowd commented Mar 21, 2024

I appreciate the time you spend into this, and Im sorry to see your time going in vain, I understand this must be frustrating. I appreciate and welcome you for future contributions here 🙏

@riosje
Copy link
Author

riosje commented Mar 21, 2024

I understand, well... nothing to do about it then.
Thanks for reviewing this.

@riosje riosje closed this Mar 21, 2024
@ovflowd
Copy link
Member

ovflowd commented Mar 21, 2024

I understand, well... nothing to do about it then. Thanks for reviewing this.

I understand the feeling, and I do see value on your points, it's just unfortunately not something we can officially support. Yet, we do have a page containing APT/YUM https://nodejs.org/en/download/package-manager/all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants