Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Translation setup for: Finnish, Dutch #6531

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Conversation

MateuszS0
Copy link
Contributor

Description

Added localization for languages: Swedish, Finnish, Dutch and Hindi to the i18n/config.json.

Validation

Related Issues

no issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@MateuszS0 MateuszS0 requested a review from a team as a code owner March 24, 2024 15:45
Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 15, 2024 3:14pm

@AugustinMauroy AugustinMauroy added the i18n Issues/PRs related to the Website Internationalisation label Mar 24, 2024
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swedishand Hindiwere added out from under this PR.

Can you adjust this PR to only add Finnish and Dutch?
Additionally, please English-alphabetize by code

Signed-off-by: Mateusz Stolarczyk <92862370+MateuszS0@users.noreply.github.com>
Copy link

github-actions bot commented Jun 15, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

Copy link

github-actions bot commented Jun 15, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.223s ⏱️

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Jun 15, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 15, 2024
@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 15, 2024
Merged via the queue into nodejs:main with commit b6c553d Jun 15, 2024
15 checks passed
@bmuenzenmeyer bmuenzenmeyer changed the title chore: Translation setup for: Swedish, Finnish, Dutch and Hindi chore: Translation setup for: Finnish, Dutch Jun 15, 2024
@bmuenzenmeyer
Copy link
Collaborator

Finnish and Dutch added in Crowdin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants