Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added greek language config #6544

Merged
merged 4 commits into from
Jun 15, 2024
Merged

added greek language config #6544

merged 4 commits into from
Jun 15, 2024

Conversation

SavvasMohito
Copy link
Contributor

Description

Adds Greek language setup to config.json to enable Greek translations on Crowdin

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Savvas Mantzouranidis <mohito6@hotmail.com>
@SavvasMohito SavvasMohito requested a review from a team as a code owner March 25, 2024 10:38
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 15, 2024 0:45am

@bmuenzenmeyer bmuenzenmeyer added the i18n Issues/PRs related to the Website Internationalisation label Mar 25, 2024
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer
Copy link
Collaborator

also alphabetized the locales, other PRs kept clobbering the end anyway

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flipped default to false 😅

i18n/config.json Outdated Show resolved Hide resolved
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Copy link

github-actions bot commented Jun 15, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

Copy link

github-actions bot commented Jun 15, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.157s ⏱️

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer
Copy link
Collaborator

added in crowdin

Merged via the queue into nodejs:main with commit e84240e Jun 15, 2024
15 checks passed
@SavvasMohito SavvasMohito deleted the patch-1 branch June 15, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants