Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hebrew language config #6580

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

joaoGabriel55
Copy link
Contributor

@joaoGabriel55 joaoGabriel55 commented Mar 28, 2024

Description

Adds Hebrew language setup to config.json to enable Hebrew translations on Crowdin

Validation

Related Issues

Related to #6551

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@joaoGabriel55 joaoGabriel55 requested a review from a team as a code owner March 28, 2024 17:48
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 15, 2024 0:40am

@AugustinMauroy AugustinMauroy added the i18n Issues/PRs related to the Website Internationalisation label Mar 28, 2024
@araujogui
Copy link
Member

araujogui commented Mar 28, 2024

LGTM, waiting for the language to be added on Crowdin.

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Copy link

github-actions bot commented Jun 15, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 88 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.097s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 15, 2024
@bmuenzenmeyer
Copy link
Collaborator

added to crowdin (or rather, already was)

Merged via the queue into nodejs:main with commit 8de7609 Jun 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants