-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Orama cloud sync based on environment #6824
CI: Orama cloud sync based on environment #6824
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Secrets Added 🖖 |
cc @micheleriva |
@ovflowd that looks good to me! |
Not sue why the discrepancies, this PR doesn't affect the website at all... |
As far as I understand; the current script works for The split in this line does not work correctly. Therefore, the script that runs later overwrites the index created in Since we will only run this script on |
Good analysis @canerakdas - I'm willing to get it a go today if we're all around to watch |
Lighthouse Results
|
Description
In the previous PRs opened (#6814, #6806), we ensured that the Orama cloud sync script updates the preview environment on
push
andpull_request_target
events.With this PR, we aim to update the production indexes using this script on the
push
event instead of manually updating it and to update the preview environment onpull_request_target
events.Additionally, to prevent these scripts from running twice, we ensure they only run on
ubuntu-latest
runners. Since we are currently running it onwindows-latest
in the preview environment, the facets are currently not displayed correctly, likely due to differences in paths on Windows (You can check it in a sample preview build)Before merging this development, the
ORAMA_PRODUCTION_INDEX_ID
andORAMA_PRODUCTION_SECRET_KEY
secrets need to be defined. I believe we should get support from @ovflowd or @bmuenzenmeyer for this 👀 I think we should first set these two values to point to the preview environment to ensure everything is working correctly, and then replace them with the production onesAdditionally, it would be helpful to ask the Orama team if indexing on every
pull_request_target
andpush
events would cause any issues on their sideRelated Issues
Related to #6719