Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Re-enable turbo flag in dev script #6836

Merged

Conversation

abizek
Copy link
Contributor

@abizek abizek commented Jun 12, 2024

Description

Next 14.2.4 is released now with the expected fix backported from canary. next dev --turbo works now but ran into a different issue with shiki (vercel/next.js#64525, vercel/next.js#63318) and added the suggested temp workaround(vercel/next.js#63318 (comment)) while the fix(vercel/next.js#64918) is being worked on.

Validation

  • Verify npm run serve works as expected.

Related Issues

Fixes #6808

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

update next to 14.2.4
update turbo to 2.0.3
transpile shiki package as temp workaround for ModuleBuildError

Signed-off-by: abizek <abishekilango@protonmail.com>
@abizek abizek requested review from a team as code owners June 12, 2024 13:05
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 12, 2024 1:08pm

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member

ovflowd commented Jun 12, 2024

Thanks for keeping an eye on this! And providing a quick fix 🙇

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F U L L T U R B O

Copy link

github-actions bot commented Jun 13, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 95 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.252s ⏱️

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 14, 2024
Merged via the queue into nodejs:main with commit 430b52c Jun 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable turbo flag in dev script
6 participants