chore: updated ESLint to v9 with flat config #7032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoshuaKGoldberg
commented
Sep 6, 2024
JoshuaKGoldberg
commented
Sep 6, 2024
JoshuaKGoldberg
commented
Sep 6, 2024
JoshuaKGoldberg
commented
Sep 6, 2024
bmuenzenmeyer
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Working locally on my machine (Windows 10)
Thanks so much for this work @JoshuaKGoldberg
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
approved these changes
Sep 6, 2024
|
With all due respect, can I just hug you, Josh?!! Thank you so much for this contribution! Very very much appreciated 😭 |
joeeames
pushed a commit
to joeeames/nodejs.org
that referenced
this pull request
Sep 24, 2024
* chore: updated ESLint to v9 with flat config * chore: missed an .eslintjscache
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps ESLint to v9 and migrates the ESLint config from the legacy "eslintrc" format (
apps/site/.eslintrc.json) to the new "flat" format (apps/site/eslint.config.js). This brought a few complications 🙃...importdoesn't have ESLint v9 support (Support eslint v9 import-js/eslint-plugin-import#2948), so I moved to its successor/rival/something-like-thatimport-xThis also butted into some pre-existing issues:
stylelint-selector-bem-patternunintentionally has a dependency on an old version ofeslint-plugin-jest, which has a dependency on an old version of@typescript-eslint/utils: Request to move eslint-plugin-jest to devDependency simonsmith/stylelint-selector-bem-pattern#72.WARNING: You are currently running a version of TypeScript ...(Set up i18n package #6991 (comment))--cachedoesn't work properly when you use cross-file linting, such asimport's cross-fine analysis. I've removed it altogether in this PR. See: https://typescript-eslint.io/troubleshooting/faqs/eslint#can-i-use-eslints---cache-with-typescript-eslintThe lines of ESLint config code are about the same if we ignore temporary flat config compatibility layers and disables for transient issues:
main: ~120 (~100.eslintrc.json+ ~20.eslintignore)eslint-9: ~120 (~150eslint.config.js- ~25 compat lines - ~5 transient disables)Validation
Broadly,
npm run lint. Specifically,npm run lint:jsandnpm run lint:mdfromapps/site.I also verified performance isn't worse in this PR. It's actually a little better! Using
time npm run+lint:jsorlint:md, ignoring Turbo caches, on an M1 Max Mac Studio...maineslint-9lint:jslint:mdRelated Issues
Parallel to #6991.
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.