Add mocking guide #7092
Merged
Add mocking guide #7092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JakobJingleheimer
force-pushed
the
art/mocking
branch
from
55ae91c
to
f54568d
Compare
JakobJingleheimer
force-pushed
the
art/mocking
branch
from
f54568d
to
1914be0
Compare
|
On first reading, it seems like a good direction to me. But I think adding a paragraph explaining the concept of ‘mock’ would be useful, as the learn section is supposed to be more explanatory than the API docs, which are very technical. I also noticed that there is no link to the mock docs API, which could be very useful. |
aduh95
reviewed
Oct 6, 2024
aduh95
reviewed
Oct 6, 2024
RedYetiDev
reviewed
Oct 7, 2024
RedYetiDev
approved these changes
Oct 7, 2024
AugustinMauroy
approved these changes
Oct 7, 2024
|
Thanks @aduh95 @AugustinMauroy @RedYetiDev ! I think it's ready to go, baring any requests from others on the test runner team. I'll wait a day to give them a chance to chime in. |
aymen94
approved these changes
Oct 8, 2024
aduh95
reviewed
Oct 8, 2024
aduh95
reviewed
Oct 8, 2024
aduh95
reviewed
Oct 8, 2024
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: Aviv Keller <redyetidev@gmail.com> Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
Co-authored-by: Aviv Keller <redyetidev@gmail.com> Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
…ith `bar`) Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
bmuenzenmeyer
force-pushed
the
art/mocking
branch
from
19c0157
to
0c26f6d
Compare
|
pushed a rebase |
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a guide for when, why, and how to mock in tests via node built-ins
Validation
Read the article :)
Related Issues
None
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.