-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 404 on the 'package managers' link on home page #7134
Conversation
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
wow - thanks so much for this @olehermanse |
Lighthouse Results
|
due to the nature of this bug and fix, I'm proposing a fast-track and will merge when ✅ green |
Description
Nodejs.org currently has a 404 link, when clicking on package managers (in all languages). AFAICT, this link has been broken for about a year and a half.
This PR fixes the issue, by using the
Link
component, which already has the correct behavior - adding the locale at the beginning of thehref
path. The issue is fixed for all languages, linking to the correct download page, and I've added a redirect, so stored / cached URLs will also start working.Validation
Tested locally, with
npx turbo dev
and it fixes the issue locally. The new links with locale at the beginning are added and the redirect also works. I don't have the config for the nginx reverse proxy used in production, in Vercel, so I cannot verify this part, but I assume it will just work.Related Issues
Somewhat similar to #7001
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.