Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 404 on the 'package managers' link on home page #7134

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

olehermanse
Copy link
Contributor

Description

Nodejs.org currently has a 404 link, when clicking on package managers (in all languages). AFAICT, this link has been broken for about a year and a half.

This PR fixes the issue, by using the Link component, which already has the correct behavior - adding the locale at the beginning of the href path. The issue is fixed for all languages, linking to the correct download page, and I've added a redirect, so stored / cached URLs will also start working.

nodejs-1
nodejs-2

Validation

Tested locally, with npx turbo dev and it fixes the issue locally. The new links with locale at the beginning are added and the redirect also works. I don't have the config for the nginx reverse proxy used in production, in Vercel, so I cannot verify this part, but I assume it will just work.

Related Issues

Somewhat similar to #7001

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse olehermanse requested a review from a team as a code owner October 22, 2024 00:58
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 22, 2024 1:01am

Copy link

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@bmuenzenmeyer
Copy link
Collaborator

wow - thanks so much for this @olehermanse
what a great example of overlooking the obvious - something a maintainer on the site wouldn't regularly click on, why better testing is necessary, and the power first-time contributors have in their curiosity and agency. 🙇

Copy link

github-actions bot commented Oct 22, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 90 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

@bmuenzenmeyer
Copy link
Collaborator

due to the nature of this bug and fix, I'm proposing a fast-track and will merge when ✅ green

Copy link

github-actions bot commented Oct 22, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.54% (594/656) 76.27% (180/236) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
134 0 💤 0 ❌ 0 🔥 5.286s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Oct 22, 2024
Merged via the queue into nodejs:main with commit cbff663 Oct 22, 2024
30 checks passed
@olehermanse olehermanse deleted the fix-404-link-home-page branch October 22, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants