-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content(learn cli): make up to date #7307
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as outdated.
This comment was marked as outdated.
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (1)
apps/site/pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md:17
- The angle brackets around the URL are unnecessary. It should be: "shebang".
You can also embed this information into your JavaScript file with a ["shebang"](<https://en.wikipedia.org/wiki/Shebang_(Unix)>) line.
apps/site/pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md
Outdated
Show resolved
Hide resolved
|
||
You can try that in the Node.js REPL, and it will print `hi!` in yellow. | ||
> **NOTE** | ||
> This part of the resource is designed with version 22.11 which notes `styleText` as ‘Active development’. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chalk is extremely popular and styleText is still in development. I don't have a strong opinion - but I feel this change might be premature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea behind this was to just talk about node and not the rest because the purpose of the learn section is to talk about node and not external packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the phrasing is odd, shouldn't mention 22.11 specifically, Learn content is always designed with LTS in mind, and it is available in LTS atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a PR to mark styleText
as stable, so it's fine nodejs/node#56265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nodejs/tsc for review, but I gave a light pass and 👍
apps/site/pages/en/learn/command-line/how-to-read-environment-variables-from-nodejs.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ruy Adorno <ruyadorno@google.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Description
styleText
APIlatest-v22.x
everywhere--run
.env
explainingValidation
v22
Related Issues
No related issues.
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.