Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix: fixed i18n and i18n types #7394

Merged
merged 1 commit into from
Jan 8, 2025
Merged

hot fix: fixed i18n and i18n types #7394

merged 1 commit into from
Jan 8, 2025

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jan 8, 2025

This PR fixes a bug introduced on a sibling PR (by me), due to types within a parent package been incorrectly typed.

Fixes #7391

@ovflowd ovflowd requested a review from a team as a code owner January 8, 2025 02:33
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 8, 2025 2:33am

@ovflowd
Copy link
Member Author

ovflowd commented Jan 8, 2025

cc @nodejs/nodejs-website I'm going to fast-track this as an Administrator as a hot-fix to fix i18n on the website.

@ovflowd ovflowd changed the title fix: fixed i18n and i18n types hot fix: fixed i18n and i18n types Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
87.6% (735/839) 74.14% (238/321) 86.58% (142/164)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.377s ⏱️

@ovflowd ovflowd merged commit 8fc5765 into main Jan 8, 2025
23 checks passed
@ovflowd ovflowd deleted the fix/fixed-locale-import branch January 8, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The translation is broken
1 participant