Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use console.error() for errors consistently #7411

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

dragunovartem99
Copy link
Contributor

@dragunovartem99 dragunovartem99 commented Jan 18, 2025

In all examples in this document errors are logged by using console.error() method

And it's unclear why in promise-based part we have different strategy

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

In all examples in this document errors are logged by using `console.error()` method

And it's unclear why in promise-based part we have different strategy

Signed-off-by: Artem Dragunov <dragunovartem99@gmail.com>
@dragunovartem99 dragunovartem99 requested a review from a team as a code owner January 18, 2025 09:05
Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 18, 2025 9:06am

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
87.55% (739/844) 74.14% (238/321) 86.58% (142/164)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.491s ⏱️

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Jan 20, 2025
Merged via the queue into nodejs:main with commit c6df7d2 Jan 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants