Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): set tabIndex to -1 #7586

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

ShubhamOulkar
Copy link
Contributor

@ShubhamOulkar ShubhamOulkar commented Mar 30, 2025

Related Issues

Closes #7585

A11y Test

correct-header-tab-sequence

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner March 30, 2025 16:07
Copy link

vercel bot commented Mar 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 30, 2025 4:08pm

@avivkeller avivkeller changed the title fix header tabbing sequence fix(header): set tabIndex to -1 Mar 30, 2025
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that this fixes the issue described

Copy link
Contributor

github-actions bot commented Mar 30, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 89 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.61% (495/585) 76.03% (165/217) 86.99% (107/123)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 5.133s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.943s ⏱️

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the ability to access the link in the announcement, I don't think that would be the desired outcome.

@avivkeller
Copy link
Member

I don't have the ability to access the link in the announcement, I don't think that would be the desired outcome.

Can you elaborate? This doesn't touch the announcement banner AFAICT.

@ShubhamOulkar
Copy link
Contributor Author

ShubhamOulkar commented Mar 31, 2025

I think you clicked somewhere else and then you checked tabbing, am I correct? Wait I have tested image stored.
a11y test

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now, I couldn't get it to work before. Sorry for the blockage, LGTM.

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ShubhamOulkar

@mikeesto mikeesto added this pull request to the merge queue Apr 1, 2025
Merged via the queue into nodejs:main with commit c3411eb Apr 1, 2025
15 checks passed
@ShubhamOulkar ShubhamOulkar deleted the tabbing-a11y branch April 1, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabbing Sequence is Broken in the header navigation
8 participants