-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(header): set tabIndex
to -1
#7586
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tabIndex
to -1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that this fixes the issue described
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the ability to access the link in the announcement, I don't think that would be the desired outcome.
Can you elaborate? This doesn't touch the announcement banner AFAICT. |
I think you clicked somewhere else and then you checked tabbing, am I correct? Wait I have tested image stored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works now, I couldn't get it to work before. Sorry for the blockage, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ShubhamOulkar
Related Issues
Closes #7585
A11y Test
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.