Skip to content

Conversation

@JakobJingleheimer
Copy link
Member

Description

Validation

Related Issues

Resolves #7267

Check List

  • I don't use pnpm

@Copilot Copilot AI review requested due to automatic review settings May 20, 2025 20:51
@JakobJingleheimer JakobJingleheimer added the content Issues/pr concerning content label May 20, 2025
@JakobJingleheimer JakobJingleheimer requested a review from a team as a code owner May 20, 2025 20:51
@vercel
Copy link

vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 23, 2025 11:00am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new introductory documentation page for Node.js userland migrations.

  • Introduces a new markdown page with an overview of userland migrations.
  • Provides code examples demonstrating how to run a migration and the resulting source modifications.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.33%. Comparing base (232e7f1) to head (9cd0b7b).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7764      +/-   ##
==========================================
+ Coverage   75.10%   75.33%   +0.22%     
==========================================
  Files          98       96       -2     
  Lines        7914     7856      -58     
  Branches      196      192       -4     
==========================================
- Hits         5944     5918      -26     
+ Misses       1969     1937      -32     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JakobJingleheimer and others added 2 commits May 20, 2025 23:02
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
@avivkeller avivkeller added the learn Issues/pr concerning the learn section label May 20, 2025
Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
@AugustinMauroy
Copy link
Member

@JakobJingleheimer put this part of learn sestion under user land team in the codeowner

Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
@JakobJingleheimer
Copy link
Member Author

@JakobJingleheimer put this part of learn sestion under user land team in the codeowner

There does not appear to be a section in codeowners for that. Are you asking me to add one there?

https://github.com/nodejs/nodejs.org/blob/main/CODEOWNERS

@AugustinMauroy
Copy link
Member

@JakobJingleheimer put this part of learn sestion under user land team in the codeowner

There does not appear to be a section in codeowners for that. Are you asking me to add one there?

https://github.com/nodejs/nodejs.org/blob/main/CODEOWNERS

yeah I mean ad the end of code owners we should add user land migration

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! cc @bmuenzenmeyer for code owner

@avivkeller
Copy link
Member

Note that adding @nodejs/userland-migrations to CODEOWNERS (and hence, giving them write access) will give write access to three users that would not otherwise have said access.

@JakobJingleheimer
Copy link
Member Author

Note that adding @nodejs/userland-migrations to CODEOWNERS (and hence, giving them write access) will give write access to three users that would not otherwise have said access.

I would prefer for the change to be in a dedicated PR than appended to a quasi-related one. Especially if the change is controversial 🙂

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 86 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 97 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit 39e3ae1 May 23, 2025
17 of 19 checks passed
@avivkeller avivkeller deleted the learn/intro-userland-migrations branch May 23, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Issues/pr concerning content learn Issues/pr concerning the learn section

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New area for userland migrations

4 participants