-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(learn/userland-migrations): add intro #7764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new introductory documentation page for Node.js userland migrations.
- Introduces a new markdown page with an overview of userland migrations.
- Provides code examples demonstrating how to run a migration and the resulting source modifications.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7764 +/- ##
==========================================
+ Coverage 75.10% 75.33% +0.22%
==========================================
Files 98 96 -2
Lines 7914 7856 -58
Branches 196 192 -4
==========================================
- Hits 5944 5918 -26
+ Misses 1969 1937 -32
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
Co-authored-by: Aviv Keller <me@aviv.sh> Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
|
@JakobJingleheimer put this part of learn sestion under user land team in the codeowner |
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
There does not appear to be a section in codeowners for that. Are you asking me to add one there? https://github.com/nodejs/nodejs.org/blob/main/CODEOWNERS |
yeah I mean ad the end of code owners we should add user land migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! cc @bmuenzenmeyer for code owner
|
Note that adding @nodejs/userland-migrations to CODEOWNERS (and hence, giving them |
I would prefer for the change to be in a dedicated PR than appended to a quasi-related one. Especially if the change is controversial 🙂 |
This reverts commit 3655407.
|
Lighthouse Results
|
Description
Validation
Related Issues
Resolves #7267
Check List