chore(chromatic): only run on ui-components changes#7785
Merged
avivkeller merged 2 commits intomainfrom May 30, 2025
Merged
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Chromatic workflow configuration to only trigger on changes in the ui-components package, serving as a workaround for the Chromatic limit.
- Limits workflow triggers to changes within the ui-components folder.
- Updates both push and pull_request_target events with the new paths filter.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aviv Keller <me@aviv.sh>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7785 +/- ##
==========================================
+ Coverage 75.34% 75.37% +0.02%
==========================================
Files 96 96
Lines 7862 7862
Branches 192 192
==========================================
+ Hits 5924 5926 +2
+ Misses 1937 1935 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjohansebas
approved these changes
May 28, 2025
ovflowd
approved these changes
May 28, 2025
Member
|
I can make the update as it being non-required. |
avivkeller
changed the title
ui-components changes and merge groupsui-components changes
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
AugustinMauroy
approved these changes
May 28, 2025
flakey5
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential workaround for our Chromatic limit, but it requires us to make
Chromatica not-required check.