fix(publish): don't use pnpm cache when not installing#7939
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents actions/setup-node from attempting to cache pnpm dependencies in the publish workflow since no installation step runs, avoiding cache lookup failures.
- Removed the
cache: pnpmoption from the setup step - Added an explanatory comment to clarify why caching is disabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7939 +/- ##
==========================================
- Coverage 75.42% 75.37% -0.05%
==========================================
Files 96 96
Lines 8354 8354
Branches 219 220 +1
==========================================
- Hits 6301 6297 -4
- Misses 2051 2055 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
AugustinMauroy
approved these changes
Jul 3, 2025
ovflowd
approved these changes
Jul 3, 2025
Member
|
Fast-tracking as a hot fix! cc @nodejs/web-infra |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per discussion in #7824 (comment), the publish matrix sometimes generates a failure in the post-step for actions/setup-node due to a cache issue. I suspect this is due to us enabling pnpm caching for actions/setup-node in this job when we never invoke
pnpm install, resulting in the post-step being unable to find dependencies to cache if a cache hit didn't occur during actions/setup-node earlier in the job.Validation
Dispatch this workflow on this branch. May need to manually delete whatever cache entry is hit and re-dispatch.Cannot publish arbitrary commits via the job, will need to merge and then test in main.
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.