Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Jul 28, 2025

Description

This is a potential solution for the linked issues, via mapping article -> api -> owner.

Prereqs:

  • @nodejs/typescript write access revoked
  • @nodejs/security-wg write access revoked1

Validation

See #8040 (comment). In a real PR, these teams will be pinged.

Related Issues

Fixes #7292
Fixes #7294

Footnotes

  1. Unless they have it for a different reason

@vercel
Copy link

vercel bot commented Jul 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 24, 2025 5:28pm

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.29%. Comparing base (bfaa6f8) to head (cd9d959).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8040      +/-   ##
==========================================
+ Coverage   76.22%   76.29%   +0.06%     
==========================================
  Files         118      118              
  Lines        9903     9903              
  Branches      337      336       -1     
==========================================
+ Hits         7549     7555       +6     
+ Misses       2352     2346       -6     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Requesting a review from the following teams:

  • nodejs/timers
  • nodejs/events
  • nodejs/repl
  • nodejs/diagnostics
  • nodejs/npm
  • nodejs/undici
  • nodejs/security-wg
  • nodejs/fs
  • nodejs/addon-api
  • nodejs/test_runner
  • nodejs/typescript

@avivkeller avivkeller marked this pull request as ready for review July 29, 2025 00:01
Copilot AI review requested due to automatic review settings July 29, 2025 00:01
@avivkeller avivkeller requested review from a team as code owners July 29, 2025 00:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new automated reviewer assignment system for Node.js documentation by mapping articles to API domains and their respective expert teams. The change replaces static CODEOWNERS assignments with dynamic review requests based on frontmatter metadata.

  • Adds api frontmatter field to 51 learning documentation files to categorize content by Node.js API domain
  • Creates automated GitHub workflow to request reviews from appropriate API expert teams
  • Removes static CODEOWNERS entries for TypeScript and security content in favor of the new dynamic system

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Multiple learn/*.md files Added api frontmatter field to categorize content by Node.js API domain
.github/workflows/request-review.yml New workflow to automatically request reviews based on API categorization
.github/scripts/get-reviewers.mjs Script to parse frontmatter and map APIs to reviewer teams
.github/reviewers.json Configuration mapping API domains to GitHub teams
.github/CODEOWNERS Removed static assignments for TypeScript and security content
Comments suppressed due to low confidence (1)

.github/scripts/get-reviewers.mjs:40

  • [nitpick] The parameter name 'content' is too generic. Consider renaming it to 'fileContent' or 'markdownContent' to better indicate what it contains.
  if (!content.trimStart().startsWith('---')) {

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 29, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 100 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 95 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 100 🔗

@avivkeller
Copy link
Member Author

Also, can someone confirm that pkgjs/request-codeowner-review is allowed in this repo, after, I can test to verify this works

Bump @nodejs/web-admins

@avivkeller
Copy link
Member Author

@ovflowd @bmuenzenmeyer bump x2

@bmuenzenmeyer
Copy link
Contributor

Sorry. Will try to look soon. Tuesdays and Wednesdays are tough for me

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avivkeller
Copy link
Member Author

Waiting for:

The action pkgjs/request-codeowner-review@0acf2fd is not allowed in nodejs/nodejs.org because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: LoveToKnow/slackify-markdown-action@, MishaKav/jest-coverage-comment@, actions-ecosystem/action-remove-labels@, chromaui/action@, codecov/codecov-action@, codecov/test-results-action@, crowdin/github-action@, gr2m/create-or-update-pull-request-action@, ossf/scorecard-action@, patrickedqvist/wait-for-vercel-preview@, pnpm/action-setup@, rtCamp/action-slack-notify@, stefanzweifel/git-auto-commit-action@, step-security/harden-runner@, thollander/actions-comment-pull-request@, treosh/lighthouse-ci-action@.

To complete testing

@avivkeller
Copy link
Member Author

Sorry. Will try to look soon. Tuesdays and Wednesdays are tough for me

@bmuenzenmeyer can you enable this action?

@bmuenzenmeyer
Copy link
Contributor

Sorry. Will try to look soon. Tuesdays and Wednesdays are tough for me

@bmuenzenmeyer can you enable this action?

@avivkeller done

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

@avivkeller
Copy link
Member Author

Testing looks good! Note that the comment was made multiple times in this PR for two different tests, in a real scenario, the comment will only be made on PR open

@avivkeller avivkeller added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit f9b57d7 Nov 24, 2025
12 checks passed
@avivkeller avivkeller deleted the add-reviewer-support branch November 24, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map and add frontmatter on learn pages tying to core apis Expand CODEOWNERS to each learn section owner/advocate