Skip to content

Conversation

@avivkeller
Copy link
Member

Fixes #7914

cc @mcollina

Copilot AI review requested due to automatic review settings September 1, 2025 13:12
@avivkeller avivkeller requested a review from a team as a code owner September 1, 2025 13:12
@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Sep 1, 2025 1:14pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the event loop documentation to clarify behavior changes introduced in Node.js v20. The change adds important information about libuv 1.45.0's modified timer execution behavior in the event loop.

Key Changes

  • Adds clarification about event loop timing changes in Node.js v20
  • Documents the shift in timer execution from before/after poll phase to only after poll phase
  • Explains potential impact on setImmediate() callback timing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.59%. Comparing base (9f16142) to head (b41b635).
⚠️ Report is 27 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8126      +/-   ##
==========================================
+ Coverage   76.56%   76.59%   +0.03%     
==========================================
  Files         115      115              
  Lines        9595     9595              
  Branches      322      321       -1     
==========================================
+ Hits         7346     7349       +3     
+ Misses       2248     2245       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Sep 10, 2025
Merged via the queue into main with commit e19e2e8 Sep 10, 2025
12 checks passed
@avivkeller avivkeller deleted the v20-event-loop branch September 10, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update event loop guide

3 participants