-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locale: add Ukrainian language #844
Conversation
also cc @nodejs/website -- I don't think some of the pages here are necessary anymore and can probably also be removed from the english version, e.g. |
Adding +1 as a @nodejs/nodejs-uk member. |
@Fishrock123 yeah, we can definitely remove otherwise, LGTM from me ✨ |
@nodejs/nodejs-uk do you need one more LGTM from your group or can i merge this? |
One more LGTM from me as a @nodejs/nodejs-uk member. |
@lac this translation is already checked by Ukrainian philologist, so we sure that everything is OK. |
Thank you! |
Very nice work! 👍 P.S. when new locales gets added, atm we have to manually enable english fallback (#490, nodejs/build#316) in the nginx config as done in nodejs/build#458. |
I've noticed a few small mistakes on the website. Gonna send pr with fixes. And it seems like font doesn't support cyrillic characters and therefore it brakes layout. Take a look at nodejs/nodejs-uk#88. |
Refs: nodejs/nodejs.org#844 PR-URL: #458 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Thanks to @denysdovhan we have Ukrainian language for NodeJS website.
/cc @nodejs/nodejs-uk