Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SVG version of new logo #884

Merged
merged 2 commits into from
Dec 4, 2016
Merged

Conversation

silverwind
Copy link
Contributor

My attempt at converting https://github.com/nodejs/nodejs.org/blob/master/static/images/logos/nodejs-new-pantone-white.ai to a small size SVG. I suspect the colors in the source file are off a bit (they are pretty dull on the 'o'), so I went ahead and manually rewrote the gradient <stop>s. Note that the gradients are a approximation. Also, I cropped the viewBox.

@silverwind
Copy link
Contributor Author

also compare with the .png:

@silverwind
Copy link
Contributor Author

The gradients need some slight tuning, will follow up.

@lpinca
Copy link
Member

lpinca commented Aug 31, 2016

Colors are only slightly different, I had to check with a color picker, can't see the difference with my eyes so looks good to me.

@silverwind silverwind force-pushed the new-logo-svg branch 19 times, most recently from 00d5ce4 to 3b6c879 Compare September 1, 2016 16:14
@silverwind
Copy link
Contributor Author

Did a few minor tweaks. I'd say it's pretty flawless now. Merge at will.

@lpinca
Copy link
Member

lpinca commented Sep 2, 2016

Can someone weigh in? The gradient difference is negligible imho, LGTM.

@fhemberger
Copy link
Contributor

FYI: I just merged #880 to get the logo issue fixed while you're fine-tuning the svg version. As soon as it's ready, please go for it!

@silverwind
Copy link
Contributor Author

I'll do one more pass on tuning the gradients.

@lpinca
Copy link
Member

lpinca commented Sep 6, 2016

I really appreciate the effort here, but can't we ask whoever designed the logo to give us the updated .ai or .svg?

@fhemberger
Copy link
Contributor

fhemberger commented Sep 6, 2016

If you can find out who did it …

It's the same with #600 (or #870). We know the AI file is incorrect, but it's hard to get someone from the Foundation (or anybody else involved) to reply.

@lpinca
Copy link
Member

lpinca commented Sep 6, 2016

@fhemberger gotcha, ignore my previous comment then.
Ping @gtewallace.

@zeke
Copy link
Contributor

zeke commented Sep 8, 2016

Thanks for making this, @silverwind. I was surprised to find that only AI files are available for download on the website.

It would be great to also link to this new SVG file from the https://nodejs.org/en/about/resources/ page.

@zeke
Copy link
Contributor

zeke commented Sep 8, 2016

cc @mikeal, who said on #526 (comment)

I have a zip file with a bunch of the noted variants in different formats.

@silverwind silverwind force-pushed the new-logo-svg branch 5 times, most recently from 077fb68 to 78ba31e Compare December 4, 2016 07:19
@silverwind
Copy link
Contributor Author

Did a few very minor tweaks to the main gradient before the merge. I'll go ahead and replace the old PNG in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants