-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve legacy CJS resolve #73
Comments
Does it matter though? I'd expect that packages that do not define a |
Not related to performance, but another problem with that function is that it seems to assume that |
Then we have 2 separate issues? Not sure the former relates to performance but we can work at both ends, should this issue reflect that? |
I started working on this issue, I will try more ideas and then share when the code is more mature. |
Hey, I created a PR for NodeJS with current work: nodejs/node#48325 I'm almost done, the performance improvements have been really nice and also bring the possibility to improve other parts of the system like |
The following code calls multiple C++ calls for each
new URL
andfileExists
function call. We can avoid these changes, make 1 C++ call, and handle the rest in the C++ layer.The text was updated successfully, but these errors were encountered: